Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: add mypy workflow #3356

Closed
wants to merge 35 commits into from
Closed

github: add mypy workflow #3356

wants to merge 35 commits into from

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Aug 4, 2024

This will run mypy only on changed files

This will run mypy only on changed files
@FrostyX
Copy link
Member Author

FrostyX commented Aug 4, 2024

Don't mind this PR (yet), I am just experimenting with static type checking

@mfocko
Copy link
Contributor

mfocko commented Aug 4, 2024

For Packit we have it in the pre-commit hooks (along with ruff), you can run it on GitHub via pre-commit.ci or GH Action

@praiskup
Copy link
Member

praiskup commented Aug 4, 2024

Have you considered enabling mypy in vcs diff lint?

@FrostyX
Copy link
Member Author

FrostyX commented Aug 9, 2024

I want to also test ruff which is gaining popularity recently. I want to borrow a configuration from opensuse-distro-aliases
https://github.com/rpm-software-management/opensuse-distro-aliases/blob/main/.github/workflows/ci.yml
They seem to be running the check only on some diff as well (poetry run ruff format --check --diff .)

@praiskup
Copy link
Member

Analysing diffs is never that interesting or powerful because it has a limited scope (the diff); what csdiff does OTOH is that it does the analysis of both old and new base codes, and only prints new issues.

@praiskup
Copy link
Member

But ruff sounds very good!

@FrostyX FrostyX closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants